handle SampleTime operator in discrete compile#3582
Open
baggepinnen wants to merge 11 commits intomasterfrom
Open
handle SampleTime operator in discrete compile#3582baggepinnen wants to merge 11 commits intomasterfrom
baggepinnen wants to merge 11 commits intomasterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/systems/systemstructure.jl
Outdated
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| end | |
| end |
AayushSabharwal
force-pushed
the
bc/external-synchronous
branch
4 times, most recently
from
76ccb08 to
cb56357
Compare
AayushSabharwal
force-pushed
the
bc/external-synchronous
branch
from
1534bd6 to
ea917fc
Compare
AayushSabharwal
force-pushed
the
bc/external-synchronous
branch
5 times, most recently
from
7fb5a65 to
600d723
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
my implementation feels inefficient, but it's not obvious to me how to improve it. It might also be nice to have this parameterized in the generated code, here the sampletime is replaced by a hard coded numerical value
this targets https://github.com/SciML/ModelingToolkit.jl/tree/bc/external-synchronous